-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqs): remove pattern validation in runtime, add override description to template #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-codes
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this quick PR!
connectors/aws/aws-sqs/element-templates/aws-sqs-boundary-connector.json
Show resolved
Hide resolved
ev-codes
changed the title
fix(sqs): add last minute fix (discussed with the team)
fix(sqs): remove pattern validation in runtime, add override description to template
Sep 27, 2024
ev-codes
added
version:8.6.0
Label that represents issues released on version 8.6.0
and removed
version:8.6.0
Label that represents issues released on version 8.6.0
labels
Sep 27, 2024
ev-codes
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed the issues now myself due to time constraints.
connectors/aws/aws-sqs/element-templates/aws-sqs-boundary-connector.json
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ion to template (#3366) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]> (cherry picked from commit 02fe7cb)
Successfully created backport PR for |
ev-codes
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ion to template (#3366) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]> (cherry picked from commit 02fe7cb)
ev-codes
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ion to template (#3366) (#3369) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]> (cherry picked from commit 02fe7cb) Co-authored-by: Mathias Vandaele <[email protected]>
ev-codes
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ion to template (#3366) (#3369) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]> (cherry picked from commit 02fe7cb) Co-authored-by: Mathias Vandaele <[email protected]>
mathias-vandaele
added a commit
that referenced
this pull request
Oct 4, 2024
…ion to template (#3366) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes allow old SQS element templates to be used with the latest Connectors runtime
Related issues
related https://github.com/camunda/team-connectors/issues/922
Checklist
no milestone
label.